qemu: Convert target_name() to TargetInfo API

Have target_name() be a target-agnostic method, dispatching
to a per-target TargetInfo singleton structure.
By default a stub singleton is used. No logical change
expected.

Inspired-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20250424222112.36194-3-philmd@linaro.org>
This commit is contained in:
Philippe Mathieu-Daudé 2025-03-23 12:47:37 +01:00
parent 802c4daf33
commit 3d881164d4
11 changed files with 70 additions and 11 deletions

View File

@ -496,7 +496,6 @@ F: include/exec/cpu*.h
F: include/exec/exec-all.h
F: include/exec/target_long.h
F: include/qemu/accel.h
F: include/qemu/target-info*.h
F: include/system/accel-*.h
F: include/system/cpus.h
F: include/accel/accel-cpu*.h
@ -505,7 +504,6 @@ F: accel/Makefile.objs
F: accel/stubs/Makefile.objs
F: cpu-common.c
F: cpu-target.c
F: target-info*.c
F: system/cpus.c
Apple Silicon HVF CPUs
@ -1928,6 +1926,13 @@ F: tests/functional/test_empty_cpu_model.py
F: tests/unit/test-smp-parse.c
T: git https://gitlab.com/ehabkost/qemu.git machine-next
TargetInfo API
M: Pierrick Bouvier <pierrick.bouvier@linaro.org>
M: Philippe Mathieu-Daudé <philmd@linaro.org>
S: Supported
F: include/qemu/target-info*.h
F: target-info*.c
Xtensa Machines
---------------
sim

View File

@ -91,8 +91,3 @@ bool target_big_endian(void)
{
return TARGET_BIG_ENDIAN;
}
const char *target_name(void)
{
return TARGET_NAME;
}

View File

@ -19,6 +19,7 @@
#include "qapi/qobject-input-visitor.h"
#include "qapi/type-helpers.h"
#include "qemu/uuid.h"
#include "qemu/target-info.h"
#include "qom/qom-qobject.h"
#include "system/hostmem.h"
#include "system/hw_accel.h"

View File

@ -1121,8 +1121,6 @@ bool cpu_exec_realizefn(CPUState *cpu, Error **errp);
void cpu_exec_unrealizefn(CPUState *cpu);
void cpu_exec_reset_hold(CPUState *cpu);
const char *target_name(void);
#ifdef COMPILING_PER_TARGET
extern const VMStateDescription vmstate_cpu_common;

View File

@ -0,0 +1,26 @@
/*
* QEMU TargetInfo structure definition
*
* Copyright (c) Linaro
*
* SPDX-License-Identifier: GPL-2.0-or-later
*/
#ifndef QEMU_TARGET_INFO_IMPL_H
#define QEMU_TARGET_INFO_IMPL_H
#include "qemu/target-info.h"
typedef struct TargetInfo {
/* runtime equivalent of TARGET_NAME definition */
const char *target_name;
} TargetInfo;
/**
* target_info:
*
* Returns: The TargetInfo structure definition for this target binary.
*/
const TargetInfo *target_info(void);
#endif

View File

@ -9,6 +9,13 @@
#ifndef QEMU_TARGET_INFO_H
#define QEMU_TARGET_INFO_H
/**
* target_name:
*
* Returns: Canonical target name (i.e. "i386").
*/
const char *target_name(void);
/**
* target_cpu_type:
*

View File

@ -3795,6 +3795,7 @@ endif
common_ss.add(pagevary)
specific_ss.add(files('page-target.c', 'page-vary-target.c'))
common_ss.add(files('target-info.c'))
specific_ss.add(files('target-info-stub.c'))
subdir('backends')

View File

@ -29,7 +29,7 @@
#include "qemu/xxhash.h"
#include "qemu/plugin.h"
#include "qemu/memalign.h"
#include "hw/core/cpu.h"
#include "qemu/target-info.h"
#include "exec/tb-flush.h"
#include "plugin.h"

View File

@ -40,6 +40,7 @@
#include "qemu/help_option.h"
#include "qemu/hw-version.h"
#include "qemu/uuid.h"
#include "qemu/target-info.h"
#include "system/reset.h"
#include "system/runstate.h"
#include "system/runstate-action.h"
@ -79,7 +80,6 @@
#include "hw/block/block.h"
#include "hw/i386/x86.h"
#include "hw/i386/pc.h"
#include "hw/core/cpu.h"
#include "migration/cpr.h"
#include "migration/misc.h"
#include "migration/snapshot.h"

View File

@ -8,8 +8,18 @@
#include "qemu/osdep.h"
#include "qemu/target-info.h"
#include "qemu/target-info-impl.h"
#include "cpu.h"
static const TargetInfo target_info_stub = {
.target_name = TARGET_NAME,
};
const TargetInfo *target_info(void)
{
return &target_info_stub;
}
const char *target_cpu_type(void)
{
return CPU_RESOLVING_TYPE;

16
target-info.c Normal file
View File

@ -0,0 +1,16 @@
/*
* QEMU target info helpers
*
* Copyright (c) Linaro
*
* SPDX-License-Identifier: GPL-2.0-or-later
*/
#include "qemu/osdep.h"
#include "qemu/target-info.h"
#include "qemu/target-info-impl.h"
const char *target_name(void)
{
return target_info()->target_name;
}